labuladong commented on code in PR #20709:
URL: https://github.com/apache/pulsar/pull/20709#discussion_r1259089651
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokersBase.java:
##########
@@ -545,16 +545,26 @@ public void shutDownBrokerGracefully(
@ApiParam(name = "maxConcurrentUnloadPerSec",
value = "if the value absent(value=0) means no concurrent
limitation.")
@QueryParam("maxConcurrentUnloadPerSec") int
maxConcurrentUnloadPerSec,
- @QueryParam("forcedTerminateTopic") @DefaultValue("true") boolean
forcedTerminateTopic
+ @QueryParam("forcedTerminateTopic") @DefaultValue("true") boolean
forcedTerminateTopic,
+ @Suspended final AsyncResponse asyncResponse
) {
- validateSuperUserAccess();
- doShutDownBrokerGracefully(maxConcurrentUnloadPerSec,
forcedTerminateTopic);
+ validateSuperUserAccessAsync()
+ .thenCompose(__ ->
doShutDownBrokerGracefullyAsync(maxConcurrentUnloadPerSec,
forcedTerminateTopic))
+ .thenAccept(__ -> {
+ LOG.info("[{}] Successfully shutdown broker gracefully",
clientAppId());
+ asyncResponse.resume(Response.noContent().build());
+ })
Review Comment:
`doShutDownBrokerGracefullyAsync` method will close the web service. After
the web service is closed, can
`asyncResponse.resume(Response.noContent().build());` work? I think we can
resume the response first, tell the admin CLI that the shutdown process has
been triggered, finish the HTTP request. Then call
`doShutDownBrokerGracefullyAsync` to do the shutdown. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
