BewareMyPower commented on code in PR #20750:
URL: https://github.com/apache/pulsar/pull/20750#discussion_r1262007324
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/NegativeAcksTest.java:
##########
@@ -146,6 +146,9 @@ public void testNegativeAcks(boolean batching, boolean
usePartitions, Subscripti
consumer.negativeAcknowledge(msg);
}
+ assertTrue(consumer instanceof ConsumerBase<String>);
+ assertEquals(((ConsumerBase<String>)
consumer).getUnAckedMessageTracker().size(), 0);
Review Comment:
Actually this test does not verify the change.
<img width="936" alt="image"
src="https://github.com/apache/pulsar/assets/18204803/1561205a-80c0-4876-8d49-90e20c3adb38";>
From the screenshot above, you can see
`consumer.unAckedMessageTracker.size()` is also 0 without the change in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
