aloyszhang commented on code in PR #20750:
URL: https://github.com/apache/pulsar/pull/20750#discussion_r1264245811
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/NegativeAcksTest.java:
##########
@@ -146,6 +146,9 @@ public void testNegativeAcks(boolean batching, boolean
usePartitions, Subscripti
consumer.negativeAcknowledge(msg);
}
+ assertTrue(consumer instanceof ConsumerBase<String>);
+ assertEquals(((ConsumerBase<String>)
consumer).getUnAckedMessageTracker().size(), 0);
Review Comment:
It's already covered by `NegativeAcksTest#variations()`.
```java
// batching / partitions / subscription-type /
negativeAck-delay-ms / ack-timeout
{ false, false, SubscriptionType.Shared, 100, 1000 },
{ false, false, SubscriptionType.Failover, 100, 1000 },
{ false, true, SubscriptionType.Shared, 100, 1000 },
{ false, true, SubscriptionType.Failover, 100, 1000 },
{ true, false, SubscriptionType.Shared, 100, 1000 },
{ true, false, SubscriptionType.Failover, 100, 1000 },
{ true, true, SubscriptionType.Shared, 100, 1000 },
{ true, true, SubscriptionType.Failover, 100, 1000 },
```
1. For `MultiTopicsConsumerImpl`: the second parameter is true means this
is a `MultiTopicsConsumerImpl`
3. For `ConsumerImpl` with the batched message: the first parameter is true
and the second is false means this a test for `ConsumerImpl` with the batched
message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
