BewareMyPower commented on code in PR #20750:
URL: https://github.com/apache/pulsar/pull/20750#discussion_r1263521985
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/NegativeAcksTest.java:
##########
@@ -146,6 +146,9 @@ public void testNegativeAcks(boolean batching, boolean
usePartitions, Subscripti
consumer.negativeAcknowledge(msg);
}
+ assertTrue(consumer instanceof ConsumerBase<String>);
+ assertEquals(((ConsumerBase<String>)
consumer).getUnAckedMessageTracker().size(), 0);
Review Comment:
Could you add a test to simulate the situations described in the motivation?
Otherwise, regression could be introduced if no tests can protect this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
