hangc0276 commented on code in PR #20935:
URL: https://github.com/apache/pulsar/pull/20935#discussion_r1289475523
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -2151,7 +2151,13 @@ public void operationFailed(ManagedLedgerException
exception) {
mdEntry.triggerFailed(exception);
}
- });
+ };
+
+ if (State.NoLedger.equals(STATE_UPDATER.get(this))) {
+ persistPositionMetaStore(mdEntry, cb);
Review Comment:
If the BookKeeper cluster runs into read-only mode and millions of consumers
keep acknowledging the mark-delete position to brokers, we will persist the
mark-delete position to the meta store without any throttle policy, will it
bring high pressure or risk for the meta store? especially when we use
Zookeeper as the Pulsar cluster's meta store service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
