codelipenghui commented on code in PR #20935:
URL: https://github.com/apache/pulsar/pull/20935#discussion_r1292913631
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -2151,7 +2151,13 @@ public void operationFailed(ManagedLedgerException
exception) {
mdEntry.triggerFailed(exception);
}
- });
+ };
+
+ if (State.NoLedger.equals(STATE_UPDATER.get(this))) {
+ persistPositionMetaStore(mdEntry, cb);
Review Comment:
> we will persist the mark-delete position to the meta store without any
throttle policy
@hangc0276 Actually, we have a throttling policy that can be configured by
`managedLedgerDefaultMarkDeleteRateLimit`. For improving this case, it looks
like we'd better have a separate one for the zookeeper. So that users can
persist to the cursor ledger for each second but persist to zookeeper for every
30 seconds.
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -2151,7 +2151,13 @@ public void operationFailed(ManagedLedgerException
exception) {
mdEntry.triggerFailed(exception);
}
- });
+ };
+
+ if (State.NoLedger.equals(STATE_UPDATER.get(this))) {
+ persistPositionMetaStore(mdEntry, cb);
Review Comment:
> we will persist the mark-delete position to the meta store without any
throttle policy
@hangc0276 @poorbarcode Actually, we have a throttling policy that can be
configured by `managedLedgerDefaultMarkDeleteRateLimit`. For improving this
case, it looks like we'd better have a separate one for the zookeeper. So that
users can persist to the cursor ledger for each second but persist to zookeeper
for every 30 seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
