hangc0276 commented on code in PR #20935:
URL: https://github.com/apache/pulsar/pull/20935#discussion_r1297090885
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -2151,7 +2151,18 @@ public void operationFailed(ManagedLedgerException
exception) {
mdEntry.triggerFailed(exception);
}
- });
+ };
+
+ if (State.NoLedger.equals(STATE_UPDATER.get(this))) {
+ if (mdEntry.newPosition.equals(ledger.getLastConfirmedEntry())) {
Review Comment:
Please update the compare logic as we discussed to cover the case that LAC's
entryId is `-1` and add a test to cover it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
