erenavsarogullari commented on a change in pull request #4539: [Pulsar-Client]
Add Producer Builder API Numeric Properties Validations
URL: https://github.com/apache/pulsar/pull/4539#discussion_r298813007
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBuilderImpl.java
##########
@@ -213,18 +214,21 @@ private ProducerBuilderImpl(PulsarClientImpl client,
ProducerConfigurationData c
@Override
public ProducerBuilder<T> batchingMaxPublishDelay(long batchDelay,
@NonNull TimeUnit timeUnit) {
+ checkArgument(batchDelay >= 0, "batchDelay needs to be >= 0");
Review comment:
Thanks for review and sorry for the late reply.
`ProducerConfigurationData` is being wrapped by `ProducerBuilderImpl` and
`ProducerConfiguration`. However, i have mentioned `ProducerConfiguration`, not
`ProducerConfigurationData`.
So, my point is that these validations exist on **deprecated**
`ProducerConfiguration` API and not exist **new** `ProducerBuilderImpl` API.
Does it make sense to align both of them as latest submitted patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
