erenavsarogullari commented on a change in pull request #4539: [Pulsar-Client]
Add Producer Builder API Numeric Properties Validations
URL: https://github.com/apache/pulsar/pull/4539#discussion_r301272425
##########
File path:
pulsar-client-1x-base/pulsar-client-1x/src/main/java/org/apache/pulsar/client/api/ProducerConfiguration.java
##########
@@ -101,7 +101,7 @@ public long getSendTimeoutMs() {
* the time unit of the {@code sendTimeout}
*/
public ProducerConfiguration setSendTimeout(int sendTimeout, TimeUnit
unit) {
- checkArgument(sendTimeout >= 0);
+ checkArgument(sendTimeout >= 0, "sendTimeout needs to be >= 0");
Review comment:
Thanks for review. The following functions require `TimeUnit` as well (apart
from the others). I agree and addressed at last patch.
```
sendTimeout(int sendTimeout, @NonNull TimeUnit unit)
batchingMaxPublishDelay(long batchDelay, @NonNull TimeUnit timeUnit)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
