erenavsarogullari commented on a change in pull request #4539: [Pulsar-Client]
Add Producer Builder API Numeric Properties Validations
URL: https://github.com/apache/pulsar/pull/4539#discussion_r298832075
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBuilderImpl.java
##########
@@ -213,18 +214,21 @@ private ProducerBuilderImpl(PulsarClientImpl client,
ProducerConfigurationData c
@Override
public ProducerBuilder<T> batchingMaxPublishDelay(long batchDelay,
@NonNull TimeUnit timeUnit) {
+ checkArgument(batchDelay >= 0, "batchDelay needs to be >= 0");
Review comment:
I agree to keep these kind of validation in single tier and support required
APIs by avoiding code duplication.
So, currently, the following `setters` look like requiring alignment on
`ProducerConfigurationData`.
```
setProducerName
setSendTimeoutMs
setMaxPendingMessages
setMaxPendingMessagesAcrossPartitions
setBatchingMaxPublishDelayMicros
setBatchingMaxMessages
```
Will be submitting new patch if we do not have any concern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
