heesung-sn commented on code in PR #21332:
URL: https://github.com/apache/pulsar/pull/21332#discussion_r1350688142
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java:
##########
@@ -503,13 +503,22 @@ public CompletableFuture<Optional<String>>
getOwnerAsync(String serviceUnit) {
case Splitting -> {
return
CompletableFuture.completedFuture(Optional.of(data.sourceBroker()));
}
- case Assigning, Releasing -> {
+ case Assigning -> {
return deferGetOwnerRequest(serviceUnit).whenComplete((__, e)
-> {
if (e != null) {
ownerLookUpCounters.get(state).getFailure().incrementAndGet();
}
- }).thenApply(
- broker -> broker == null ? Optional.empty() :
Optional.of(broker));
+ }).thenApply(broker -> broker == null ? Optional.empty() :
Optional.of(broker));
+ }
+ case Releasing -> {
+ if (isTransferCommand(data)) {
+ return deferGetOwnerRequest(serviceUnit).whenComplete((__,
e) -> {
+ if (e != null) {
+
ownerLookUpCounters.get(state).getFailure().incrementAndGet();
+ }
+ }).thenApply(broker -> broker == null ? Optional.empty() :
Optional.of(broker));
+ }
+ return CompletableFuture.completedFuture(Optional.empty());
Review Comment:
Also, we have the leader broker who should watch any stuck states and fix
the stuck state. Do we know why the monitor didn't kick in this case and
didin't complete the future(maybe because of the delay)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
