Demogorgon314 commented on code in PR #21332:
URL: https://github.com/apache/pulsar/pull/21332#discussion_r1353976322


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -2193,6 +2193,21 @@ private CompletableFuture<Integer> 
unloadServiceUnit(NamespaceBundle serviceUnit
             if (serviceUnit.includes(topicName)) {
                 // Topic needs to be unloaded
                 log.info("[{}] Unloading topic", topicName);
+                if (topicFuture.isCompletedExceptionally()) {

Review Comment:
   @lhotari 
   > Did the exception now change to this one?
   
   Yes, after we marked the current unload bundle as having no owner, the 
`__change_events ` will still try to get topic, so it will get 
`ServiceUnitNotReadyException` exception.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to