Demogorgon314 commented on code in PR #21332:
URL: https://github.com/apache/pulsar/pull/21332#discussion_r1351110853
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java:
##########
@@ -503,13 +503,22 @@ public CompletableFuture<Optional<String>>
getOwnerAsync(String serviceUnit) {
case Splitting -> {
return
CompletableFuture.completedFuture(Optional.of(data.sourceBroker()));
}
- case Assigning, Releasing -> {
+ case Assigning -> {
return deferGetOwnerRequest(serviceUnit).whenComplete((__, e)
-> {
if (e != null) {
ownerLookUpCounters.get(state).getFailure().incrementAndGet();
}
- }).thenApply(
- broker -> broker == null ? Optional.empty() :
Optional.of(broker));
+ }).thenApply(broker -> broker == null ? Optional.empty() :
Optional.of(broker));
+ }
+ case Releasing -> {
+ if (isTransferCommand(data)) {
+ return deferGetOwnerRequest(serviceUnit).whenComplete((__,
e) -> {
+ if (e != null) {
+
ownerLookUpCounters.get(state).getFailure().incrementAndGet();
+ }
+ }).thenApply(broker -> broker == null ? Optional.empty() :
Optional.of(broker));
+ }
+ return CompletableFuture.completedFuture(Optional.empty());
Review Comment:
The monitor will clean up this state, but we should unblock it for admin API
since we don't want the admin API timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
