Demogorgon314 commented on code in PR #21408:
URL: https://github.com/apache/pulsar/pull/21408#discussion_r1372498930
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -2190,8 +2190,10 @@ public CompletableFuture<Void>
checkTopicNsOwnership(final String topic) {
}
public CompletableFuture<Integer> unloadServiceUnit(NamespaceBundle
serviceUnit,
Review Comment:
Should we add a new method for this public method change instead of adding a
new parameter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
