dragosvictor commented on code in PR #21408:
URL: https://github.com/apache/pulsar/pull/21408#discussion_r1378256679
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java:
##########
@@ -801,11 +802,29 @@ protected void handleError(CommandError error) {
@Override
protected void handleCloseProducer(CommandCloseProducer closeProducer) {
- log.info("[{}] Broker notification of Closed producer: {}",
remoteAddress, closeProducer.getProducerId());
final long producerId = closeProducer.getProducerId();
ProducerImpl<?> producer = producers.remove(producerId);
if (producer != null) {
- producer.connectionClosed(this);
+ if (closeProducer.hasAssignedBrokerServiceUrl() ||
closeProducer.hasAssignedBrokerServiceUrlTls()) {
+ try {
+ final URI uri = new URI(producer.client.conf.isUseTls()
+ ? closeProducer.getAssignedBrokerServiceUrlTls()
+ : closeProducer.getAssignedBrokerServiceUrl());
+ log.info("[{}] Broker notification of Closed producer: {}.
Redirecting to {}.",
+ remoteAddress, closeProducer.getProducerId(), uri);
+ producer.getConnectionHandler().connectionClosed(this, 0L,
Optional.of(uri));
+ } catch (URISyntaxException e) {
+ log.error("[{}] Invalid redirect url {}/{} for {}",
remoteAddress,
+ closeProducer.getAssignedBrokerServiceUrl(),
+ closeProducer.getAssignedBrokerServiceUrlTls(),
Review Comment:
`GetAssignedBrokerServiceUrl` or `GetAssignedBrokerServiceUrlTls` could
throw an `InvalidStateException` if the respective value is not present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
