gaoran10 commented on code in PR #21408:
URL: https://github.com/apache/pulsar/pull/21408#discussion_r1382017183
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -1760,6 +1762,20 @@ protected void handleSend(CommandSend send, ByteBuf
headersAndPayload) {
printSendCommandDebug(send, headersAndPayload);
}
+
+ ServiceConfiguration conf =
getBrokerService().pulsar().getConfiguration();
+ if (producer.getTopic().isFenced()
+ &&
ExtensibleLoadManagerImpl.isLoadManagerExtensionEnabled(conf)) {
Review Comment:
Do we need to add a boolean field to cache the result of the check
`ExtensibleLoadManagerImpl.isLoadManagerExtensionEnabled(conf)`?
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionHandler.java:
##########
@@ -66,6 +68,10 @@ protected ConnectionHandler(HandlerState state, Backoff
backoff, Connection conn
}
protected void grabCnx() {
+ grabCnx(Optional.empty());
+ }
+
+ protected void grabCnx(Optional<URI> hostURI) {
Review Comment:
Maybe we can add `@Nonnull` annotation for param `Optional<URI> hostUrl`, or
else we still need to check if it's null.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java:
##########
@@ -484,14 +485,22 @@ private CompletableFuture<Void> delete(boolean
failIfHasSubscriptions, boolean c
return deleteFuture;
}
+
+ @Override
+ public CompletableFuture<Void> close(boolean
closeWithoutWaitingClientDisconnect) {
+ return close(false, closeWithoutWaitingClientDisconnect);
+ }
+
/**
* Close this topic - close all producers and subscriptions associated
with this topic.
*
+ * @param closeWithoutDisconnectingClients don't disconnect clients
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
