AnonHxy commented on PR #21461: URL: https://github.com/apache/pulsar/pull/21461#issuecomment-1786482035
Hi @liudezhi2098 . This patch will not lead incompatible issue I think: 1. Resource quotas are written to `/loadbalance/resource-quota` only by `BundlesQuotas`. https://github.com/apache/pulsar/blob/bc84721694aa0e7d42b1ccc1cc6af378f48350eb/pulsar-broker/src/main/java/org/apache/pulsar/broker/cache/BundlesQuotas.java#L61-L65 2. `ModularLoadManagerImpl` only read the zpath specified by `RESOURCE_QUOTA_ZPATH=/loadbalance/resource-quota/namespace`. Currently the read result should always be empty because the zpath is wrong. https://github.com/apache/pulsar/blob/bc84721694aa0e7d42b1ccc1cc6af378f48350eb/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java#L384-L387 3. And the `LoadSimulationController` should be used for test. We needn't care about it's incompatibility -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
