AnonHxy commented on code in PR #21461:
URL: https://github.com/apache/pulsar/pull/21461#discussion_r1383503038
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java:
##########
@@ -106,7 +106,7 @@ public class ModularLoadManagerImpl implements
ModularLoadManager {
public static final int NUM_SHORT_SAMPLES = 10;
// Path to ZNode whose children contain ResourceQuota jsons.
- public static final String RESOURCE_QUOTA_ZPATH =
"/loadbalance/resource-quota/namespace";
Review Comment:
`RESOURCE_QUOTA_ZPATH = "/loadbalance/resource-quota/namespace"` was
introduced from this PR:https://github.com/apache/pulsar/pull/329. And we can
see that the motivation is just try to use historical data from old API in new
API.
So the impact of wrong zk path is that we just couldn't use the historical
data from old API, making the default message rate and throughput values not
nice enought. It will not cause data loss or other critical issues.
I have added a UT to cover this change. PTAL @codelipenghui @poorbarcode
@BewareMyPower
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
