poorbarcode commented on code in PR #21461:
URL: https://github.com/apache/pulsar/pull/21461#discussion_r1383277879


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java:
##########
@@ -106,7 +106,7 @@ public class ModularLoadManagerImpl implements 
ModularLoadManager {
     public static final int NUM_SHORT_SAMPLES = 10;
 
     // Path to ZNode whose children contain ResourceQuota jsons.
-    public static final String RESOURCE_QUOTA_ZPATH = 
"/loadbalance/resource-quota/namespace";

Review Comment:
   > @AnonHxy Could you please help add a test to cover this fix? And from the 
description, I still don't know what is the impact here. Is it something that 
doesn't work? how to reproduce it?
   
   +1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to