RobertIndie commented on code in PR #174:
URL:
https://github.com/apache/pulsar-client-python/pull/174#discussion_r1424245709
##########
setup.py:
##########
@@ -80,7 +80,7 @@ def build_extension(self, ext):
extras_require["functions"] = sorted(
{
"protobuf>=3.6.1,<=3.20.3",
- "grpcio>=1.8.2",
+ "grpcio>=1.60.0",
Review Comment:
This is the dependency requirement instead of the specific dependency
version. It's not like the dependency version control like in maven pom. I
think maybe a good practice is to upgrade the requirement to the minimum viable
version. What do you think of this point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
