RobertIndie commented on code in PR #174:
URL:
https://github.com/apache/pulsar-client-python/pull/174#discussion_r1424954149
##########
setup.py:
##########
@@ -80,7 +80,7 @@ def build_extension(self, ext):
extras_require["functions"] = sorted(
{
"protobuf>=3.6.1,<=3.20.3",
- "grpcio>=1.8.2",
+ "grpcio>=1.60.0",
Review Comment:
> Another question: what if users introduced another dependency compatible
with grpcio 1.60 but not with 1.53.0?
That should be a common case. Support we use `grpcio>=1.53.0`, then that
`another dependency` should define the requirements with `grpcio>=1.60.0`. The
pip will upgrade the grpcio to 1.60, and everything should be fine.
> However, you assume the existing grpcio version is in [1.53, 1.60). If the
grpcio version is less than 1.53, there will be no difference.
Why? I am assuming the grpcio version <1.60.
Suppose we have another dependency A that requires grpcio version in
[1.40,1.55].
If the existing grpcio version < 1.53(Let's suppose it as 1.40) :
1. If we use `grpcio>=1.53.0`, the pip will upgrade the grpcio to 1.53.0.
All works fine.
2. If we use `grpcio>=1.60.0`, the pip will uggrade the grpcio to 1.60.0.
The dependency A isn't compatible with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
