RobertIndie commented on code in PR #174:
URL:
https://github.com/apache/pulsar-client-python/pull/174#discussion_r1424772219
##########
setup.py:
##########
@@ -80,7 +80,7 @@ def build_extension(self, ext):
extras_require["functions"] = sorted(
{
"protobuf>=3.6.1,<=3.20.3",
- "grpcio>=1.8.2",
+ "grpcio>=1.60.0",
Review Comment:
What if users introduce another dependency compatible with grpcio 1.53.0 but
not with 1.60? Maybe that dependency depends on a behavior supported in 1.53.0
but not 1.60.0? When installing the Python client, the pip will upgrade the
existing grpcio to 1.60.0, which may conflict with other dependencies.
I didn't find any breaking changes from grpcio 1.53.0 to 1.60.0. So I'm OK
with this PR. However, I would like to discuss the best practice for the
dependency requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
