Technoboy- commented on code in PR #21745:
URL: https://github.com/apache/pulsar/pull/21745#discussion_r1430212896
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1231,37 +1232,53 @@ private void
asyncDeleteCursorWithClearDelayedMessage(String subscriptionName,
if (ex != null) {
unsubscribeFuture.completeExceptionally(ex);
} else {
- asyncDeleteCursor(subscriptionName, unsubscribeFuture);
+ asyncDeleteCursor(subscriptionName, persistentSubscription,
unsubscribeFuture);
}
});
}
- private void asyncDeleteCursor(String subscriptionName,
CompletableFuture<Void> unsubscribeFuture) {
- ledger.asyncDeleteCursor(Codec.encode(subscriptionName), new
DeleteCursorCallback() {
- @Override
- public void deleteCursorComplete(Object ctx) {
- if (log.isDebugEnabled()) {
- log.debug("[{}][{}] Cursor deleted successfully", topic,
subscriptionName);
- }
- removeSubscription(subscriptionName);
- unsubscribeFuture.complete(null);
- lastActive = System.nanoTime();
- }
+ private void asyncDeleteCursor(String subscriptionName,
Review Comment:
we can remove `subscriptionName`, only use `subscription`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
