codelipenghui commented on code in PR #21745:
URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436839434
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1220,7 +1221,7 @@ private void
asyncDeleteCursorWithClearDelayedMessage(String subscriptionName,
if (ex != null) {
unsubscribeFuture.completeExceptionally(ex);
} else {
Review Comment:
I think we should stop the compaction if the topic is deleted.
After checking the code, it looks like the RawReader will create the topic
again if the topic auto-creation is enabled on the broker-side. Will it cause a
topic deletion failure if there is a running compactor?
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PulsarCompactorSubscription.java:
##########
@@ -106,5 +108,16 @@ public void markDeleteFailed(ManagedLedgerException
exception, Object ctx) {
}
}
+ CompletableFuture<Void> cleanCompactedLedger() {
Review Comment:
We have `TopicCompactionService` now, shall we add an new API to the
`TopicCompactionService`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
