poorbarcode commented on code in PR #21781:
URL: https://github.com/apache/pulsar/pull/21781#discussion_r1436214595
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java:
##########
@@ -49,44 +55,55 @@ public class ResourceGroupConfigListener implements
Consumer<Notification> {
private final ResourceGroupResources rgResources;
private final ResourceGroupNamespaceConfigListener
rgNamespaceConfigListener;
+ @SneakyThrows
public ResourceGroupConfigListener(ResourceGroupService rgService,
PulsarService pulsarService) {
this.rgService = rgService;
this.pulsarService = pulsarService;
this.rgResources =
pulsarService.getPulsarResources().getResourcegroupResources();
- loadAllResourceGroups();
+ loadAllResourceGroupsAsync()
+
.get(pulsarService.getConfiguration().getMetadataStoreOperationTimeoutSeconds(),
TimeUnit.SECONDS);
Review Comment:
> Could I use get() or join()?
I think it is worse than `get timeout`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
