nodece commented on code in PR #21781:
URL: https://github.com/apache/pulsar/pull/21781#discussion_r1436232503
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListenerTest.java:
##########
@@ -288,4 +298,27 @@ private void prepareData() throws PulsarAdminException {
testAddRg.setDispatchRateInBytes(200L);
}
+
+ @Test
+ public void testLoadAllResourceGroupsAsyncFailed() {
Review Comment:
> But for now implementation, you ignored the Exception when accepting a
Notification of resource group changes, it would cause the same error you
mentioned in Motivation, right?
For the resource group changes(reload/update), it always ignored the
Exception.
When new `ResourceGroupConfigListener` and
`ResourceGroupNamespaceConfigListener`, they will load the resource groups and
namespace to cache to bind the namespace and resource groups. But loading the
resource groups is async, so the `ResourceGroupNamespaceConfigListener` cannot
find the resource groups from the cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
