poorbarcode commented on code in PR #21781: URL: https://github.com/apache/pulsar/pull/21781#discussion_r1436215958
########## pulsar-broker/src/test/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListenerTest.java: ########## @@ -288,4 +298,27 @@ private void prepareData() throws PulsarAdminException { testAddRg.setDispatchRateInBytes(200L); } + + @Test + public void testLoadAllResourceGroupsAsyncFailed() { Review Comment: I think you should add a test that responds to an error `Resource group does not exist: rg-1`, the same as the case you provided in the motivation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org