codelipenghui commented on PR #21739: URL: https://github.com/apache/pulsar/pull/21739#issuecomment-1869898118
@dao-jun Do we still need to make changes to `ManagedLedgerImpl.java`? As I understand, if we applied the `combined skip condition`, we will leverage the existing skip condition support in ManagedLedgerImpl, right? If the skip condition support in ManagedLedgerImpl need to improve or fix. Is it possible to move to another PR to keep this PR well-scoped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
