dao-jun commented on code in PR #21739:
URL: https://github.com/apache/pulsar/pull/21739#discussion_r1457204295
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -3406,6 +3411,9 @@ public LongPairRangeSet<PositionImpl>
getIndividuallyDeletedMessagesSet() {
}
public boolean isMessageDeleted(Position position) {
+ if (this instanceof ReadOnlyCursor) {
+ return false;
+ }
Review Comment:
Yes, override is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
