dao-jun commented on PR #21739: URL: https://github.com/apache/pulsar/pull/21739#issuecomment-1871000062
> @dao-jun > > Do we still need to make changes to `ManagedLedgerImpl.java`? As I understand, if we applied the `combined skip condition`, we will leverage the existing skip condition support in ManagedLedgerImpl, right? If the skip condition support in ManagedLedgerImpl need to improve or fix. Is it possible to move to another PR to keep this PR well-scoped. Yes, because of message skipCondition, one single segment can be spit into segments, such as: entries to be filter-out: [3, 5, 7] entries to read: [1, 10] then, it will be split into: [[1,2],[4], [6], [8,10]], right? In the previous implementation, after read [1,2] finished, then begin to read [4], after read [4] finished, then start to read [6]... I believe it will lead to latency increasing, memory(allocated for entries) will also be retained for a longer period of time, it will affect the throughput of the system. So I tried to read these segments `parallel`, and it would make changes to `ManagedLedgerImpl`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
