jayshrivastava opened a new pull request, #1165:
URL: https://github.com/apache/pulsar-client-go/pull/1165
<!--
### Motivation
The producer's `Flush` method does not respect context cancellation. If the
caller's context get's cancelled, the producer will block forever.
### Modifications
The producer's `Flush` method now takes a context and selects on two
channels.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change is already covered by existing tests. See code changes for
relevant tests.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): no
- The public API: yes
- The schema: no
- The default values of configurations: no
- The wire protocol: no
### Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
- If a feature is not applicable for documentation, explain why? It's a
very trivial change. It adds a common pattern in Go.
- If a feature is not documented yet in this PR, please create a followup
issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
