merlimat commented on code in PR #1165:
URL: https://github.com/apache/pulsar-client-go/pull/1165#discussion_r1473584578
##########
pulsar/producer.go:
##########
@@ -239,7 +239,7 @@ type Producer interface {
// Flush all the messages buffered in the client and wait until all
messages have been successfully
// persisted.
- Flush() error
+ Flush(ctx context.Context) error
Review Comment:
While I agree that we should have taking the context in this method, right
now this would be a breaking API change.
I'd say to add a new `FlushWithContext()` method and, perhaps, mark the
other one as deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
