jayshrivastava commented on code in PR #1165:
URL: https://github.com/apache/pulsar-client-go/pull/1165#discussion_r1473614608
##########
pulsar/producer.go:
##########
@@ -239,7 +239,7 @@ type Producer interface {
// Flush all the messages buffered in the client and wait until all
messages have been successfully
// persisted.
- Flush() error
+ Flush(ctx context.Context) error
Review Comment:
I can't implement `CloseWithCtx` such as in this PR because goroutines might
leak (the call to close would terminate before the signal is given on the
doneCh, indicating that things have shut down). I think it would be a bigger
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
