onobc commented on code in PR #546:
URL: https://github.com/apache/pulsar-manager/pull/546#discussion_r1483168961
##########
src/main/java/org/apache/pulsar/manager/utils/HttpUtil.java:
##########
@@ -130,7 +130,7 @@ public static void initHttpClient() {
}
}
- public static String doGet(String url, Map<String, String> header){
Review Comment:
This is a breaking change. While this class is probably an internal util -
it is still marked public and well, people will likely be using it even if they
are not "supposed to" :)
Unless it is really needed I would just go back to static access. My 2c.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
