onobc commented on code in PR #546:
URL: https://github.com/apache/pulsar-manager/pull/546#discussion_r1483421192
##########
src/main/java/org/apache/pulsar/manager/utils/HttpUtil.java:
##########
@@ -130,7 +130,7 @@ public static void initHttpClient() {
}
}
- public static String doGet(String url, Map<String, String> header){
Review Comment:
> I removed static from most of these methods because I wanted to get rid of
powermock which succeeded.
It's also not the best design to make things static while it can perfectly
be a bean and depending classes it's tests can rely on mockito to mock it out,
like I did when I replaced it with powermock.
I completely agree w/ all of the reasoning.
> who is using this class besides some internal classes within this project?
Agreed, it would only be a breaking change if it is being used elsewhere. I
don't think its clearly labeled internal. I am ok w/ making that "label" now
though w/ these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
