onobc commented on code in PR #546:
URL: https://github.com/apache/pulsar-manager/pull/546#discussion_r1483426807
##########
build.gradle:
##########
@@ -14,7 +14,7 @@
buildscript {
ext {
- springBootVersion = '2.0.2.RELEASE'
+ springBootVersion = '2.5.3'
Review Comment:
> I don't see such a big leap as going from the current state the project is
in towards spring-boot 3 as a possibility.
Its mostly due to the slew of other SB starters the project uses that are
far from Boot3. The other piece we will run into quickly is included libs on
`javax.*` and not `jakarta.*`.
I think stepping up version/version like you are doing here will make this
more do-able.
> but I think it had something to do with circular references.
Yep, in 2.6.0 this is enforced. You can temp workaround via:
```
spring:
main:
allow-circular-references: true
```
##########
build.gradle:
##########
@@ -14,7 +14,7 @@
buildscript {
ext {
- springBootVersion = '2.0.2.RELEASE'
+ springBootVersion = '2.5.3'
Review Comment:
> I don't see such a big leap as going from the current state the project is
in towards spring-boot 3 as a possibility.
Its mostly due to the slew of other SB starters the project uses that are
far from Boot3. The other piece we will run into quickly is included libs on
`javax.*` and not `jakarta.*`.
I think stepping up version/version like you are doing here will make this
more do-able.
> but I think it had something to do with circular references.
Yep, in 2.6.0 this is enforced. You can temp workaround via:
```
spring:
main:
allow-circular-references: true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
