lhotari commented on code in PR #22054:
URL: https://github.com/apache/pulsar/pull/22054#discussion_r1490751837
##########
docker/pulsar/scripts/install-glibc-compat.sh:
##########
@@ -18,13 +18,18 @@
# under the License.
#
-set -x
+set -e -x
-# TODO: remove these lines once grpcio doesn't need to compile from source on
ARM64 platform
-ARCH=$(uname -m | sed -r 's/aarch64/arm64/g' | awk '!/arm64/{$0="amd64"}1')
-if [ "${ARCH}" == "arm64" ]; then
- apt update
- apt -y install build-essential python3-dev
+ARCH=$(uname -m)
+if [ "$ARCH" == "x86_64" ]
+then
+ cd /tmp
+ echo 'https://storage.sev.monster/alpine/edge/testing' | tee -a
/etc/apk/repositories
+ wget
https://storage.sev.monster/alpine/edge/testing/x86_64/sevmonster-keys-1-r0.apk
+ apk add --no-cache --allow-untrusted ./sevmonster-keys-1-r0.apk
+ apk update
+ apk add gcompat libuuid
+ rm /lib/ld-linux-x86-64.so.2
+ apk add --no-cache --force-overwrite glibc glibc-bin
+ rm *.apk
Review Comment:
Why is this needed? Where is the homepage of this repository? Isn't
`gcompat`, `libgcc` and `libstdc++`/`libstdc++6` sufficient alone?
It looks like the sevmonster repository doesn't contain arm64 support.
Is it a security risk to trust the sevmonster repository?
If we need true glibc, there's also the possibility to use [Bellsoft's JDK
base images](https://bell-sw.com/libericajdk-containers/#docker-hub-images)
which support JDK on glibc on Alpine.
This is
[liberica-openjdk-alpine](https://hub.docker.com/r/bellsoft/liberica-openjdk-alpine)'s
Dockerfile:
https://github.com/bell-sw/Liberica/blob/master/docker/repos/liberica-openjdk-alpine/21/Dockerfile
Liberica JDK is also used in [Apache Nifi's
Dockerfile](https://github.com/apache/nifi/blob/main/nifi-docker/dockerhub/Dockerfile#L20).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
