merlimat commented on code in PR #22054:
URL: https://github.com/apache/pulsar/pull/22054#discussion_r1491580112
##########
docker/pulsar/scripts/install-glibc-compat.sh:
##########
@@ -18,13 +18,18 @@
# under the License.
#
-set -x
+set -e -x
-# TODO: remove these lines once grpcio doesn't need to compile from source on
ARM64 platform
-ARCH=$(uname -m | sed -r 's/aarch64/arm64/g' | awk '!/arm64/{$0="amd64"}1')
-if [ "${ARCH}" == "arm64" ]; then
- apt update
- apt -y install build-essential python3-dev
+ARCH=$(uname -m)
+if [ "$ARCH" == "x86_64" ]
+then
+ cd /tmp
+ echo 'https://storage.sev.monster/alpine/edge/testing' | tee -a
/etc/apk/repositories
+ wget
https://storage.sev.monster/alpine/edge/testing/x86_64/sevmonster-keys-1-r0.apk
+ apk add --no-cache --allow-untrusted ./sevmonster-keys-1-r0.apk
+ apk update
+ apk add gcompat libuuid
+ rm /lib/ld-linux-x86-64.so.2
+ apk add --no-cache --force-overwrite glibc glibc-bin
+ rm *.apk
Review Comment:
The most problem I had were with with Kinesis producer lib (for the
Pulsar-IO kinesis connector). It uses boost and a whole bunch of dependencies
on Glibc.
> It looks like the sev.monster might be publishing similar packages as
https://github.com/sgerrand/alpine-pkg-glibc /
https://github.com/sgerrand/docker-glibc-builder .
I was just trying to get a quick solution to see that Kinesis producer was
working. I saw they had last prebuilt latest version, since the other ones on
https://github.com/sgerrand/alpine-pkg-glibc are not working on Alpine 3.19.
I definitely agree we shouldn't depend on these binary repo.
I would still prefer to use Corretto JVM linked with musl. Mainly so that:
1. we can always control the base OS version, without depending on this
OpenJDK provider to have a release
2. the track record of Corretto in the last years
In the end, I would prefer to just build the Glibc as a pre-step, so we'd be
having both x86_64 and arm binaries and no dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
