lhotari commented on code in PR #22054:
URL: https://github.com/apache/pulsar/pull/22054#discussion_r1490763940


##########
docker/pulsar/scripts/install-glibc-compat.sh:
##########
@@ -18,13 +18,18 @@
 # under the License.
 #
 
-set -x
+set -e -x
 
-# TODO: remove these lines once grpcio doesn't need to compile from source on 
ARM64 platform
-ARCH=$(uname -m | sed -r 's/aarch64/arm64/g' |  awk '!/arm64/{$0="amd64"}1')
-if [ "${ARCH}" == "arm64" ]; then
-  apt update
-  apt -y install build-essential python3-dev
+ARCH=$(uname -m)
+if [ "$ARCH" == "x86_64" ]
+then
+  cd /tmp
+  echo 'https://storage.sev.monster/alpine/edge/testing' | tee -a 
/etc/apk/repositories
+  wget 
https://storage.sev.monster/alpine/edge/testing/x86_64/sevmonster-keys-1-r0.apk
+  apk add --no-cache --allow-untrusted ./sevmonster-keys-1-r0.apk
+  apk update
+  apk add gcompat libuuid
+  rm /lib/ld-linux-x86-64.so.2
+  apk add --no-cache --force-overwrite glibc glibc-bin
+  rm *.apk

Review Comment:
   Looks like linking is fine for libcirce-checksum.so
   ```
   ❯ docker run --rm -it merlimat/pulsar:3.3.0-SNAPSHOT-f2a91a1 bash -c 'cd 
/tmp;unzip /pulsar/lib/org.apache.bookkeeper-circe-checksum-4.16.4.jar 
lib/*;ldd lib/libcirce-checksum.so'
   Archive:  /pulsar/lib/org.apache.bookkeeper-circe-checksum-4.16.4.jar
      creating: lib/
     inflating: lib/libcirce-checksum.so
        /lib/ld-musl-x86_64.so.1 (0x7a6468661000)
        libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x7a64683c3000)
        libc.so.6 => /lib/ld-musl-x86_64.so.1 (0x7a6468661000)
        libgcc_s.so.1 => /usr/lib/libgcc_s.so.1 (0x7a646839f000)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to