asafm commented on code in PR #22058:
URL: https://github.com/apache/pulsar/pull/22058#discussion_r1497629900
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/testcontext/PulsarTestContext.java:
##########
@@ -727,11 +733,24 @@ protected void initializePulsarServices(SpyConfig
spyConfig, Builder builder) {
.equals(PulsarCompactionServiceFactory.class.getName())) {
compactionServiceFactory = new
MockPulsarCompactionServiceFactory(spyConfig, builder.compactor);
}
+ PulsarBrokerOpenTelemetry pulsarBrokerOpenTelemetry;
+ if (builder.enableOpenTelemetry) {
+ var reader = InMemoryMetricReader.create();
+ pulsarBrokerOpenTelemetry = new
PulsarBrokerOpenTelemetry(builder.config, builderCustomizer -> {
+ builderCustomizer.addMeterProviderCustomizer(
+ (meterProviderBuilder, __) ->
meterProviderBuilder.registerMetricReader(reader));
+ builderCustomizer.addPropertiesSupplier(
+ () ->
Map.of(OpenTelemetryService.OTEL_SDK_DISABLED_KEY, "false"));
+ });
+ openTelemetryMetricReader(reader);
Review Comment:
I'm starting to dislike this Lombok :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
