dragosvictor commented on code in PR #22058:
URL: https://github.com/apache/pulsar/pull/22058#discussion_r1504794246
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -175,6 +199,12 @@ public NamespaceService(PulsarService pulsar) {
this.bundleSplitListeners = new CopyOnWriteArrayList<>();
this.localBrokerDataCache =
pulsar.getLocalMetadataStore().getMetadataCache(LocalBrokerData.class);
this.redirectManager = new RedirectManager(pulsar);
+
+ this.lookupLatencyHistogram = pulsar.getOpenTelemetry().getMeter()
+ .histogramBuilder("pulsar.broker.lookup.request.duration")
+ .setDescription("Lookup request duration")
+ .setUnit("s")
Review Comment:
The OpenTelemetry semantic conventions recommend using seconds as a unit of
time for duration measurements
([ref](https://opentelemetry.io/docs/specs/semconv/general/metrics/#instrument-units)).
It's not mandated that we follow this, but I think it makes sense to
standardize on one unit of measurement for this purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
