dragosvictor commented on code in PR #22058:
URL: https://github.com/apache/pulsar/pull/22058#discussion_r1498399395
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/PulsarBrokerOpenTelemetry.java:
##########
@@ -34,10 +37,17 @@ public class PulsarBrokerOpenTelemetry implements Closeable
{
private final Meter meter;
public PulsarBrokerOpenTelemetry(ServiceConfiguration config) {
+ this(config, null);
+ }
+
+ @VisibleForTesting
+ public PulsarBrokerOpenTelemetry(ServiceConfiguration config,
+
Consumer<AutoConfiguredOpenTelemetrySdkBuilder> builderCustomizer) {
openTelemetryService = OpenTelemetryService.builder()
.clusterName(config.getClusterName())
.serviceName(SERVICE_NAME)
.serviceVersion(PulsarVersion.getVersion())
+ .sdkBuilderConsumer(builderCustomizer)
Review Comment:
Renamed to `builderCustomizer` and added to `PulsarService` constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]