visortelle commented on code in PR #789:
URL: https://github.com/apache/pulsar-site/pull/789#discussion_r1501034072
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -24,14 +24,12 @@ export default function CommunityPage(): JSX.Element {
<Button title={isShowMoreCmtrs ? 'Show less' : 'Show more'}
variant="transparentWhite" onClick={() =>
setIsShowMoreCmtrs(!isShowMoreCmtrs)}/>
);
- const forbiddenUsers = ['jianghaiting', 'technoboy', 'linlin']
- const currectUsers = ['Jason918', 'Technoboy-', '315157973']
-
- const correctUsersExceptions = (element) => {
- if(forbiddenUsers.indexOf(element.apacheId) !== -1){
- element.apacheId =
currectUsers[forbiddenUsers.indexOf(element.apacheId)];
- }
- return element
+ type apacheId = string
Review Comment:
```suggestion
type ApacheId = string
```
The common TypeScript convention is to use capitalized CamelCase for type
names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
