visortelle commented on PR #789: URL: https://github.com/apache/pulsar-site/pull/789#issuecomment-1962382741
@asafm ok ;) Than I have a few more comments for the "Community Page": - [ ] Discussion section items title should use bold font **Design** <img width="1308" alt="Screenshot 2024-02-24 at 5 42 47 PM" src="https://github.com/apache/pulsar-site/assets/9302460/efdf54ca-4329-4db4-892a-26d16ed87bc5";> **Implementation** <img width="873" alt="Screenshot 2024-02-24 at 5 44 09 PM" src="https://github.com/apache/pulsar-site/assets/9302460/b37f2d92-d7ff-4a38-a369-81662a6eb59b";> - [ ] The order of discussion channels is different in Figma. - [ ] The section color is different - [ ] The font size is different 22px vs 32px **Design** <img width="676" alt="Screenshot 2024-02-24 at 5 47 33 PM" src="https://github.com/apache/pulsar-site/assets/9302460/10157a88-fa7c-4bdf-8b3f-0f20dc5d910e";> **Implementation** <img width="816" alt="Screenshot 2024-02-24 at 5 47 07 PM" src="https://github.com/apache/pulsar-site/assets/9302460/ed0dc46a-265b-4a8c-b2ee-6b97372de94d";> - [ ] Font size should be smaller here. 32px vs 40px <img width="596" alt="Screenshot 2024-02-24 at 5 52 16 PM" src="https://github.com/apache/pulsar-site/assets/9302460/396c344a-b11f-4f48-9151-dc576bf84fad";> - [ ] Vertical padding should be bigger according to the design <img width="972" alt="Screenshot 2024-02-24 at 5 53 49 PM" src="https://github.com/apache/pulsar-site/assets/9302460/fb88c9e1-e2cc-4571-b5d2-295f6f134ac6";> - [ ] Font size should be smaller here according the design <img width="619" alt="Screenshot 2024-02-24 at 5 54 54 PM" src="https://github.com/apache/pulsar-site/assets/9302460/f0a8d5cd-0a14-4bb3-8504-7cf37fc436bb";> - [ ] Font size should be smaller here..18px vs 24px <img width="981" alt="Screenshot 2024-02-24 at 5 57 02 PM" src="https://github.com/apache/pulsar-site/assets/9302460/240a09b5-989d-47f8-8189-790f15e697bd";> - [ ] Vertical padding should be smaller here. - [ ] Font size should be bigger. <img width="873" alt="Screenshot 2024-02-24 at 5 57 42 PM" src="https://github.com/apache/pulsar-site/assets/9302460/43487919-4695-40b9-8e02-638f21b7e552";> - [ ] Vertical padding should be smaller - [ ] Items should be vertically centered - [ ] Font size should be different <img width="1438" alt="Screenshot 2024-02-24 at 5 59 26 PM" src="https://github.com/apache/pulsar-site/assets/9302460/bb210f32-a0d6-439d-8728-939434a29565";> @Trakina could you please go through font sizes and paddings across the other pages and make the corresponding fixes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
