BewareMyPower commented on code in PR #22827:
URL: https://github.com/apache/pulsar/pull/22827#discussion_r1634501022
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java:
##########
@@ -297,10 +297,10 @@ private LoadSheddingStrategy createLoadSheddingStrategy()
{
Thread.currentThread().getContextClassLoader());
} catch (Exception e) {
log.error("Error when trying to create load shedding strategy: {}",
- conf.getLoadBalancerLoadPlacementStrategy(), e);
+ conf.getLoadBalancerLoadSheddingStrategy(), e);
}
- log.error("create load shedding strategy failed. using OverloadShedder
instead.");
- return new OverloadShedder();
+ log.error("create load shedding strategy failed. using
ThresholdShedder by default.");
+ return new ThresholdShedder();
Review Comment:
@congbobo184 because it is returned only when
`loadBalancerLoadSheddingStrategy` is configured with an incorrect value (e.g.
a class that does not exist).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
