BewareMyPower commented on code in PR #22827:
URL: https://github.com/apache/pulsar/pull/22827#discussion_r1634505365
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java:
##########
@@ -297,10 +297,10 @@ private LoadSheddingStrategy createLoadSheddingStrategy()
{
Thread.currentThread().getContextClassLoader());
} catch (Exception e) {
log.error("Error when trying to create load shedding strategy: {}",
- conf.getLoadBalancerLoadPlacementStrategy(), e);
+ conf.getLoadBalancerLoadSheddingStrategy(), e);
Review Comment:
Actually I think it would be better to fail fast here rather than falling
back to a default configured class. Unlike `createNamespaceUnloadStrategy`, the
default configured `ThresholdShedder` cannot be used to construct a
`NamespaceUnloadStrategy` used for extensible load manager so it falls back to
`TransferShedder` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
