BewareMyPower commented on code in PR #22827:
URL: https://github.com/apache/pulsar/pull/22827#discussion_r1634631278
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java:
##########
@@ -297,10 +297,9 @@ private LoadSheddingStrategy createLoadSheddingStrategy() {
Thread.currentThread().getContextClassLoader());
} catch (Exception e) {
log.error("Error when trying to create load shedding strategy: {}",
Review Comment:
The exception will be caught and logged in `PulsarService#start`, so I think
we can just simply not catch the exception here.
```java
private LoadSheddingStrategy createLoadSheddingStrategy() {
return
Reflections.createInstance(conf.getLoadBalancerLoadSheddingStrategy(),
LoadSheddingStrategy.class,
Thread.currentThread().getContextClassLoader());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
