codelipenghui commented on PR #23298: URL: https://github.com/apache/pulsar/pull/23298#issuecomment-2346849457
> Currently, step 1 and 2 are performed by the distribution lock implemented by LockManager. However, there should be no race condition because the broker id is the unique identifier of a broker. There is no case that a broker starts or closes concurrently. In addition, it's meaningless to pass a version explicitly to the metadata store. @BewareMyPower But it could happen from user's incorrect configuration that more than 1 brokers use the same broker id especially for a on-prem environment. And the comment https://github.com/apache/pulsar/pull/23297#discussion_r1757265763 is also the same concern about the lock issue. It looks like something cause the lock didn't get released even if the broker unregister itself from the metadata server. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
