BewareMyPower commented on code in PR #23298:
URL: https://github.com/apache/pulsar/pull/23298#discussion_r1758263872
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/BrokerRegistryImpl.java:
##########
@@ -122,7 +119,7 @@ public boolean isStarted() {
public synchronized void register() throws MetadataStoreException {
if (this.state == State.Started) {
try {
- this.brokerLookupDataLock =
brokerLookupDataLockManager.acquireLock(keyPath(brokerId), brokerLookupData)
+ brokerLookupDataMetadataCache.put(brokerIdKeyPath,
brokerLookupData)
Review Comment:
I added the `CreateOption` parameter now. PTAL again @lhotari
BTW, I just read the code about `MetadataStoreExtended`. This API seems not
designed well. Currently, built-in implementation all implement this interface.
If it does not force the 3rd party library to implement the extra interfaces,
it should be documented that where are these methods be used and what will
happen if they are not implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
