BewareMyPower commented on code in PR #23298:
URL: https://github.com/apache/pulsar/pull/23298#discussion_r1758150655
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/BrokerRegistryImpl.java:
##########
@@ -122,7 +119,7 @@ public boolean isStarted() {
public synchronized void register() throws MetadataStoreException {
if (this.state == State.Started) {
try {
- this.brokerLookupDataLock =
brokerLookupDataLockManager.acquireLock(keyPath(brokerId), brokerLookupData)
+ brokerLookupDataMetadataCache.put(brokerIdKeyPath,
brokerLookupData)
Review Comment:
It's still confusing to me for why did we introduce `MetadataStoreExtended`
and in which case `MetadataStore` is not a `MetadataStoreExtended`. Currently
`MetadataCache` just maintains a `MetadataStore` internally. Let me read more
details first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
